Structs?
Jun 6, 2013 at 6:19am UTC
Can someone please explain to me how I can integrate structs into my code? It'll make it much smaller because I don't like it being 200+ lines of code. What my code basically does is it asks you to input a height and a width and the program will make a 2D grid of that and it will find the largest product of 4 numbers. It runs and compiles correctly, I would just like to make it smaller.
structs largest_product_info
{
int HEIGHT;
int WIDTH;
string shape;
}
1 #include <iostream>
#include <fstream>
#include <cstdlib>
using namespace std;
#define NUMBER_OF_CONSECUTIVE_DIGITS 4
int main()
{
int index = 0;
int WIDTH,HEIGHT;
do {
cout<<"Enter Width" <<endl;
cin>>WIDTH;
if (cin.fail()){
cin.clear(); cin.ignore(1000, '\n' );
cout << "Please enter a valid integer\n" ;
continue ;
}
if (WIDTH <=3) {
cout << "Please enter a width > 3\n" ;
}
else
{
break ;
}
}while (1);
do {
cout<<"Enter Height" <<endl;
cin>>HEIGHT;
if (cin.fail()){
cin.clear(); cin.ignore(1000,'\n' );
cout << "Please enter a valid integer\n" ;
continue ;
}
if (HEIGHT <= 3){
cout << "Please enter a height >3\n" ;
}
else
{
break ;
}
}while (1);
int grid[ WIDTH ][ HEIGHT ];
double temp = 1;
int width = 0;
int height = 0;
int max_start_index_x = 0;
int max_start_index_y = 0;
double max_product = 0;
int what_type_of_consecutive = 0; // 1 = horizontal, 2 = vertical
// 3 = diaganol-down-right, 4 = diaganol-up-right
int i = 0;
int x = 0;
int y = 0;
int j=0;
//filling with random values less than 100
for (i=0;i<WIDTH;i++)
{
for (j=0;j<HEIGHT;j++)
{
grid[ i ][ j ] = rand()%100;
}
}
i=0;
j=0;
//Searches from left to right.
for ( y = 0; y < HEIGHT; y++ )
{
for (x = 0; x <= WIDTH - NUMBER_OF_CONSECUTIVE_DIGITS; x++)
{
for ( i = 0; i < NUMBER_OF_CONSECUTIVE_DIGITS; i++)
{
temp *= grid [x + i ] [ y ];
}
if ( temp > max_product )
{
max_product = temp;
max_start_index_x = x;
max_start_index_y = y;
what_type_of_consecutive = 1;
}
temp = 1;
}
}
temp = 1;
//Searches from top-bottom
for ( x = 0; x < WIDTH; x++ )
{
for ( y = 0; y <= HEIGHT - NUMBER_OF_CONSECUTIVE_DIGITS; y++ )
{
for ( i = 0; i < NUMBER_OF_CONSECUTIVE_DIGITS; i++ )
{
temp *= grid[ x ][ y + i ];
}
if ( temp > max_product )
{
max_product = temp;
max_start_index_x = x;
max_start_index_y = y;
what_type_of_consecutive = 2;
}
temp = 1;
}
}
temp = 1;
//Diagonal Down-right
for ( x = 0; x <= WIDTH - NUMBER_OF_CONSECUTIVE_DIGITS; x++ )
{
for ( y = 0; y <= HEIGHT - NUMBER_OF_CONSECUTIVE_DIGITS; y++ )
{
for (i = 0; i < NUMBER_OF_CONSECUTIVE_DIGITS; i++ )
{
temp *= grid[ x + i][ y + i ];
}
if ( temp > max_product )
{
max_product = temp;
max_start_index_x = x;
max_start_index_y = y;
what_type_of_consecutive = 3;
}
temp = 1;
}
}
temp = 1;
//Diagonal up-right
for ( x = 0; x <= WIDTH - NUMBER_OF_CONSECUTIVE_DIGITS; x++ )
{
for ( y = HEIGHT - 1; y >= NUMBER_OF_CONSECUTIVE_DIGITS - 1; y-- )
{
for ( i = 0; i < NUMBER_OF_CONSECUTIVE_DIGITS; i++ )
{
temp *= grid[ x + i ][ y - i ];
}
if ( temp > max_product)
{
max_product = temp;
max_start_index_x = x;
max_start_index_y = y;
what_type_of_consecutive = 4;
}
temp = 1;
}
}
if ( what_type_of_consecutive != 0 )
{
cout.setf( ios_base::fixed, ios_base::floatfield );
cout.precision( 0 );
cout << "\n\nThe greatest product for " << NUMBER_OF_CONSECUTIVE_DIGITS << " consecu tive digits is: " << max_product << "\n" ;
cout << "It starts at point: (" << max_start_index_x + 1 << ", " << max_start_index_ y + 1 << ") and the digits are in " ;
switch ( what_type_of_consecutive )
{
case 1:
cout << "horizontal order.\n" ;
cout << "The digits are: " ;
for ( i = max_start_index_x; i < max_start_index_x + NUMBER_OF_CONSECUTIVE_DIG ITS; i++ )
{
cout << grid[ i] [ max_start_index_y ] << " " ;
}
cout << "\n" ;
break ;
case 2:
cout << "vertical order.\n" ;
cout << "The digits are: " ;
for ( i = max_start_index_y; i < max_start_index_y + NUMBER_OF_CONSECUTIVE_DIG ITS; i++ )
{
cout << grid[ max_start_index_x ][ i ] << " " ;
}
cout << "\n" ;
break ;
case 3:
cout << "diagonal-down-right order.\n" ;
cout << "The digits are: " ;
for ( i = 0; i < NUMBER_OF_CONSECUTIVE_DIGITS; i++ )
{
cout << grid[ max_start_index_x + i ][ max_start_index_y - i ] << " " ;
}
cout << "\n" ;
break ;
case 4:
cout << "diagonal-up-right order.\n" ;
cout << "The digits are: " ;
for ( i = 0; i < NUMBER_OF_CONSECUTIVE_DIGITS; i++)
{
cout << grid[ max_start_index_x + i ][ max_start_index_y - i ] << " " ;
}
cout << "\n" ;
break ;
}
}
else
{
cout << "\nThe grid is not big enough to find a number with " << NUMBER_OF_CONSECUTIVE_DIGITS;
cout << " consecutive digits.\n" ;
}
cout << "\n\n" ;
return 0;
}
Jun 6, 2013 at 7:54am UTC
If you really want to make the code shorter, the answer is likely to lie in employing functions, not structs.
Jun 6, 2013 at 12:50pm UTC
We're practicing structs in class so I want to play around with it and practice.
Jun 7, 2013 at 6:19am UTC
No help in the forums?
Jun 7, 2013 at 6:52am UTC
Well you finished the struct 50 %.
1structs largest_product_info
{
int HEIGHT , WIDTH;
std::string shape;
}
int main()
{
largest_product_info lpi;
std::cout << "Height: " << std::flush;
std::cin >> lpi.HEIGHT;
std::cout << "Width: " << std::flush;
std::cin >> lpi.WIDTH;
std::cout << "Shape: " << std::flush;
std::cin >> lpi.shape;
}
Also I believe that std::endl; makes the program run slightly faster than '\n' but maybe only a ms and imo
std::cout << std::endl; looks better than
std::cout << '\n' ; or even
std::cout << '\n' << std::flush;
Last edited on Jun 7, 2013 at 6:55am UTC
Topic archived. No new replies allowed.
