How does this not work?

[Dominic4774]

It was working before, I don't know what I did, but i've searched and searched and can't find any reason for this not to work. I don't get any errors, but when it Should say "Student 1 is now set to name" It says "Student 1 is now set to ".
I can post the full code if needed, but it's kind of long.

#include <iostream>
#include <string>
#include<conio.h>
#include <cstdlib>
using namespace std;


class STUDENTS{

public:

    void getname1(string x){
     name1 = x;
    }
    void getname2(string y){
     name2 = y;
    }
    void getname3(string z){
     name3 = z;
    }
    string setname1(){
    return name1;
    }
    string setname2(){
    return name2;
    }
    string setname3(){
    return name3;
    }
private:
    string name1;
    string name2;
    string name3;


};


int main(){

char choice;
string name1;
string name2;
string name3;
string over;




cout << "Please choose a name to change first. Type [Exit] to close" << endl;
cout << "Student [1]: " << name1 << "\nStudent [2]: " << name2 << "\nStudent [3]: " << name3 << endl;
cin >> choice;
if(choice == '1'){
        STUDENTS inwin;
        system("cls");
        cout << "Type the name of the student" << endl;
        cin >> name1;
        inwin.getname1(name1);
        cout << name1 << " correct? y/n" << endl;
        cin >> choice;
}
    if(choice == 'y'){
        system("cls");
        cout << "Student [1]: " << name1 << " \nStudent [2]: " << name2 << " \nStudent [3]: " << name3 << endl;
        cout << "\n";
        cout << "\n";
        cout << "Student 1 is now set to " << name1 << endl;
}

    if(choice == 'n'){
        while(choice == 'n'){
        STUDENTS inwin;
        cout << "Type the name of the student" << endl;
        cin >> name1;
        inwin.getname1(name1);
        cout << name1 << " correct? y/n" << endl;
        cin >> choice;
}
        system("cls");
        cout << "Student [1]: " << name1 << " \nStudent [2]: " << name2 << " \nStudent [3]: " << name3 << endl;
        cout << "\n";
        cout << "\n";
        cout << "Student 1 is now set to " << name1 << endl;

    }

if(choice == '2'){
        STUDENTS inwin;
        system("cls");
        cout << "Type the name of the student" << endl;
        cin >> name2;
        inwin.getname2(name2);
        cout << name2 << " correct? y/n" << endl;
        cin >> choice;
}
    if(choice == 'y'){
        system("cls");
        cout << "Student [1]: " << name1 << " \nStudent [2]: " << name2 << " \nStudent [3]: " << name3 << endl;
        cout << "\n";
        cout << "\n";
        cout << "Student 1 is now set to " << name2 << endl;
}

    if(choice == 'n'){
        while(choice == 'n'){
        STUDENTS inwin;
        cout << "Type the name of the student" << endl;
        cin >> name2;
        inwin.getname1(name2);
        cout << name2 << " correct? y/n" << endl;
        cin >> choice;
}
        system("cls");
        cout << "Student [1]: " << name1 << " \nStudent [2]: " << name2 << " \nStudent [3]: " << name3 << endl;
        cout << "\n";
        cout << "\n";
        cout << "Student 2 is now set to " << name2 << endl;

    }








    return 0;

}

[MiiNiPaa]

where do you initialize name1 variable?

[fmehri76]

It seems that name1 isn't initialized yet. Recheck where you initialized it.

[Dominic4774]

I posted the full code, I thought I had initialized it, but maybe not, this is only my second day of coding.

[MiiNiPaa]

There is a fallthrough:
you have 2 conditions where choice == 'y' is tested. Both will be executed. As second one clears screen, you will only see it no matter what. And it uses name2.
Delete all system calls and see for yourself. I have ssen it immideatly because cls will not work fo me or anybody using linux.

[Dominic4774]

How do you recommend fixing this? I thought since they were in two different bodys things like that would be fine

[MikeyBoy]

It would be much easier for both you and us to follow the logic of your code if you adopted a sensible indentation style.

[Dominic4774]

Alright, will do. Didn't know there was a such thing as a coding style, but I'll start coding in one from now on.

[Chervil]

http://en.wikipedia.org/wiki/Indent_style

This can be a subject for religious wars, so tread carefully :)

[fmehri76]

Dominic4774, you can solve the problem like this:
delete the closing brackets in lines 61 and 95 then put them in lines 86 and 120.
this way you will solve the problem MiiNiPaa mentioned.

[Dominic4774]

Thanks