Is this formatted correctly?

[TheSuperPhreak]

Hey guys! I am still very new to C++ and am currently learning about converting decimal to binary, and binary math. I decided to try and make a simple program that converts it for you, using the remainder method for conversion. My program works, but my question is do I have the format right? Or is it jumbled up. I don't know if I put things like the global variables and the prototyping in the correct spots.

#include <iostream>
using namespace std;

void binarycompile(int remainder);

string binary;
string bit;

int main(){
    int remainder;
    int current;

    cout << "Type the decimal number to convert to binary:  ";
    cin >> current;
    cout << endl << endl << "Binary = ";

    do{
    remainder = current % 2;
    current = current / 2;
    binarycompile(remainder);
    }while(current > 0);

    binarycompile(2);
    cout << endl << endl << "Press enter to quit.";
    cin.get();
    cin.get();
    return 0;
}
void binarycompile(int remainder){
    switch (remainder){
        case 0:
                bit = "0";
                binary = bit + binary;
                break;
            case 1:
                bit = "1";
                binary = bit + binary;
                break;
            default:
                cout << binary;
        }
}

[Pickle Gunner]

I think its really personal preference... It doesn't really matter unless its extremely bad.

[TheSuperPhreak]

Just found out that neg's will not work so I amended the code to this:

#include <iostream>
using namespace std;

void binarycompile(int remainder);

string binary, bit;
int negcheck = 0;

int main(){
    int remainder;
    int current;

    cout << "Type the positive number to convert to binary:  ";
    cin >> current;
    if(current <= -1){
          negcheck = 1;
          current = current * -1;
    }
    cout << endl << endl << "Binary = ";
    do{
    remainder = current % 2;
    current = current / 2;
    binarycompile(remainder);
    }while(current > 0);

    binarycompile(2);
    cout << endl << endl << "Press enter to quit.";
    cin.get();
    cin.get();
    return 0;
}
void binarycompile(int remainder){
    switch (remainder){
        case 0:
                bit = "0";
                binary = bit + binary;
                break;
            case 1:
                bit = "1";
                binary = bit + binary;
                break;
            default:
                if(negcheck == 1){
                    binary = "-" + binary;
                }
                cout << binary;
        }
}

[Ispil]

I recommend removing binary and bit as global variables by moving them under the function binarycompile. They're only used there, after all.

[TheSuperPhreak]

Ah very true. I had them as global before because instead of a default case with a cout in it, I had the function type as string and return binary; but it wouldn't return with the variables inside the function. Changing that now, thanks for pointing it out!