Access Violation in C

[Shervan360]

Hello,

I have the below error: (line 8)
Exception thrown at 0x7928E63C (ucrtbased.dll) in C_1.exe: 0xC0000005: Access violation writing location 0x00BA0000. occurred

How can I fix this?

#include <stdio.h>
#include<stdlib.h>


void getName(char names[][100], int i)
{
	printf_s("Enter Name: ");
	scanf_s("%s", names[i]);
}
void getFamily(char families[][100], int i)
{
	printf_s("Enter Family: ");
	scanf_s("%s", families[i]);

}
void Print(char names[][100], char families[][100], int i)
{
	printf_s("%s", names[i]);
	printf_s("\t");
	printf_s("%s", families[i]);
	printf_s("\n");
}

int main()
{
	char names[10][100];
	char families[10][100];

	for (int i = 0; i < 3; i++)
	{
		getName(names, i);
		getFamily(families, i);
	}
	printf_s("\n");
	for (int i = 0; i < 3; i++)
	{
		Print(names, families, i);
	}

	return 0;
}

[Repeater]

Use string instead of char arrays. They manage their own memory.

[Shervan360]

@Repeater
Thank you, but I don't want to use C++.
I want to use char of array.

[Repeater]

What input values are you entering that breaks it? You're probably overflowing the arrays. Don't do that. Don't try to store more characters in the arrays than they have space for.

[salem c]

scanf_s may be 'safer', but that doesn't mean you can stop paying attention.

For one thing, you don't just tack on an "_s" to the function call, and voila, instant safety.

https://docs.microsoft.com/en-us/cpp/c-runtime-library/reference/scanf-s-scanf-s-l-wscanf-s-wscanf-s-l?view=vs-2019
The buffer size parameters you completely forgot will be garbage.

That VS still can't diagnose that you're not even remotely using the function correctly is another fail.

[Ganado]

main.cpp(9): warning C4473: 'scanf_s' : not enough arguments passed for format string
main.cpp(9): note: placeholders and their parameters expect 2 variadic arguments, but 1 were provided
main.cpp(9): note: the missing variadic argument 2 is required by format string '%s'
main.cpp(9): note: this argument is used as a buffer size
main.cpp(14): warning C4473: 'scanf_s' : not enough arguments passed for format string
main.cpp(14): note: placeholders and their parameters expect 2 variadic arguments, but 1 were provided
main.cpp(14): note: the missing variadic argument 2 is required by format string '%s'

VS diagnoses it fine (although I'm compiling in C++).

[salem c]

Good to know - thanks Ganado.