can someone improve it (chess game)

[Maimaje Bello Abdullahi]

I've got almost all of my code busted out, but one of my queens doesn't show up (still interacts with the board, kind of), and i get a random 'X' floating around.. please, someone should look at my code and find a little thing that keeps throwing me for a loop..

And i want someone to help improve my code using classes.. thanks

i posted my code in the beginners forum but, the respond is very limited..
http://www.cplusplus.com/forum/beginner/24147/

#include <iostream>
#include <cstdio>

using namespace std;

#define BOARD_W 4
#define BOARD_H 4

void generate(char[][BOARD_H]);
void display(char[][BOARD_H]);
bool validate(char);
bool validate(char[][BOARD_H], int, int);
void mark(char[][BOARD_H], int, int);
bool check(char[][BOARD_H]);
bool check(char[][BOARD_H],int,int);

int main()
{
    bool finish = false, valid_reply = false;
    char board[BOARD_W][BOARD_H];
    char reply;
    int count1, count2;
    
    while(finish != true)
    {
                 for(count1 = 0; count1 < BOARD_W; count1++)
                 {
                            for(count2 = 0; count2 < BOARD_H; count2++)
                            {
                                       board[count1][count2] = '.';
                            }
                 }
                 generate(board);
                 display(board);
                 
                 //Asks for another go, and ends if told no.
                 while(valid_reply != true)
                 {
                                   cout << "\n\nWould you like to generate another configuration? (y/n)";
                                   cin >> reply;
                                   valid_reply = validate(reply);
                                   if(reply == 'n')
                                       finish = true;
                                   else
                                       finish = false;
                 }
                 valid_reply = false;
    }
}

void generate(char board[][BOARD_H])
{
     int W;
     int H;
     bool valid = false;
     do
     {
          W = rand()%(BOARD_W);
          H = rand()%(BOARD_H);
          while(board[W][H] != '.')
          {
                          W = rand()%BOARD_W;
                          H = rand()%BOARD_H;
          }
          mark(board, W, H);
          board[W][H] = 'Q';
          cout << endl << H + 1 << " " << W + 1 << " " << check(board) << endl; //DEBUG LINE  */
     }
     while(check(board) != true);
}

void display(char board[][BOARD_H])
{
     int count, count1;
     for(count1 = 0; count1 < BOARD_H; count1 ++)
     {
                cout << "\n";
                for(count = 0; count < BOARD_W; count++)
                {
                          cout << " -";
                }
                cout << " \n";
                for(count = 0; count < BOARD_W; count++)
                {
                          cout << "|" << board[count][count1];
                }
                cout << "|";
     }
     cout << "\n";
     for(count = 0; count < BOARD_W; count++)
     {
                cout << " -";
     }
}

bool validate(char reply)
{
     if(reply == 'y' || reply == 'n')
              return true;
     else
              return false;
}

void mark(char board[][BOARD_H], int W, int H)
{
     int W1, H1, count1;
     W1 = W;
     H1 = H;
     while(W1 > 0 && H1 > 0)
     {
            W1-- && H1--;
            board[W1][H1] = 'X';
     }
     W1 = W;
     H1 = H;
     while(W1 <= BOARD_W && H1 > 0)
     {
            W1++ && H1--;
            board[W1][H1] = 'X';
     }
     W1 = W;
     H1 = H;
     while(W1 > 0 && H1 <= BOARD_H)
     {
            W1-- && H1++;
            board[W1][H1] = 'X';
     }
     W1 = W;
     H1 = H;
     while(W1 <= BOARD_W && H1 <= BOARD_H)
     {
            W1++ && H1++;
            board[W1][H1] = 'X';
     }
     for(count1 = 0; count1 < BOARD_W; count1++)
     {
                board[count1][H] = 'X';
     }
     for(count1 = 0; count1 < BOARD_H; count1++)
     {
                board[W][count1] = 'X';
     }
     board[W][H] = 'Q';
     return;
}

bool check(char board[][BOARD_H])
{
     bool done = true;
     int count, count2;
     for(count = 0; count < BOARD_W; count++)
     {
               for(count2 = 0; count2 < BOARD_H; count2++)
               {
                          if(board[count][count2] == '.')
                                                  done = false;
               }
     }
     return done;
}

bool check(char board[][BOARD_H], int W, int H)
{
     int W1, H1, count1;
     W1 = W;
     H1 = H;
     while(W1 > 0 && H1 > 0)
     {
            W1-- && H1--;
            if(board[W1][H1] == 'Q')
                             return false;
     }
     W1 = W;
     H1 = H;
     while(W1 <= BOARD_W && H1 > 0)
     {
            W1++ && H1--;
            if(board[W1][H1] == 'Q')
                             return false;
     }
     W1 = W;
     H1 = H;
     while(W1 > 0 && H1 <= BOARD_H)
     {
            W1-- && H1++;
            if(board[W1][H1] == 'Q')
                             return false;
     }
     W1 = W;
     H1 = H;
     while(W1 <= BOARD_W && H1 <= BOARD_H)
     {
            W1++ && H1++;
            if(board[W1][H1] == 'Q')
                             return false;
     }
     for(count1 = 0; count1 < BOARD_W; count1++)
     {
                if(board[W1][H1] == 'Q')
                             return false;
     }
     for(count1 = 0; count1 < BOARD_H; count1++)
     {
                if(board[W1][H1] == 'Q')
                             return false;
     }
     return true;
}

[RedX]

could not reproduce your problem

[Maimaje Bello Abdullahi]

yes, i know i'm not suppose to re-post my problem.. but, i posted it here because i want to compile my code on the Unix Environment and the respond in beginners forums is very limited..

[Albatross]

A good place to post problems like this is the General C++ forum. But... don't repost or ask it to be moved.

I get no Xs floating around.

-Albatross

[Denis]

bool validate(char reply)
{
     return (reply == 'y' || reply == 'n');
}

[Denis]

void initBoard(char** board, int w, int h)
{
    for(int i(0); i < w; ++i)
    {
        for(int j(0); j < w; ++j)
        {
            board[i][j] = '.';
        }
    }
}

int main()
{
    char board[BOARD_W][BOARD_H];

    bool finish(false);
    while(!finish)
    {
        initBoard(board, BOARD_W, BOARD_H)
        generate(board);
        display(board);

        //Asks for another go, and ends if told no.
        char reply(0);
        while(true)
        {
            cout << "\n\nWould you like to generate another configuration? (y/n)";
            cin >> reply;
            if (validate(reply) && reply == 'n')
            {
                finish = true;
                break;
            }
        }
    }
}

[Denis]

void initBoard(char** board, int w, int h)
{
    for(int i(0); i < w; ++i)
        for(int j(0); j < w; ++j)
            board[i][j] = '.';
}
void generate(char** board, int w, int h)
{
    do
    {
        int x(0);
        int y(0);
        do
        {
            x = rand() % w;
            y = rand() % h;
        } while(board[x][y] != '.');
        mark(board, x, y);
        board[x][y] = 'Q';
    }
    while(!check(board));
}
int main()
{
    char board[BOARD_W][BOARD_H];

    bool finish(false);
    while(!finish)
    {
        initBoard(board, BOARD_W, BOARD_H);
        generate(board, BOARD_W, BOARD_H);
        display(board);

        //Asks for another go, and ends if told no.
        char reply(0);
        while(true)
        {
            cout << "\n\nWould you like to generate another configuration? (y/n)";
            cin >> reply;
            if (validate(reply) && reply == 'n')
            {
                finish = true;
                break;
            }
        }
    }
}