Tic Tac Toe

[tinkydwd123]

Hi, I have been working on this Tic Tac Toe project for literally over 40 hours the last few weeks, and I cannot get it to work right. Right now I'm working on the twoHuman() function, haven't even gotten to the rest yet, so ignore what is there. The problem I'm having is that When there is a winner, it does not recognize it. Same thing if there is a scratch. Here is my code:

#include <iostream> 
#include <iomanip> 
#include "ttt.h" 
using namespace std;

char status;
int counter = 0;

ttt::ttt() // constructor initializes the  board
{
	 for ( int j = 0; j < 3; j++ ) 

      for ( int k = 0; k < 3; k++ )
         board_[ j ][ k ] = ' ';
}


char ttt::CheckForWinner()
{   
   int a;

   // check for a win on diagonals
   if ( board_[ 0 ][ 0 ] != ' ' && board_[ 0 ][ 0 ] == board_[ 1 ][ 1 ] &&
       board_[ 0 ][ 0 ] == board_[ 2 ][ 2 ] )
	   {
	   status = board_[ 0 ][ 0 ];
       cout << "Player" << status << "wins!!!";
	   return status;
	   }
   else if ( board_[ 2 ][ 0 ] != ' ' && board_[ 2 ][ 0 ] == 
      board_[ 1 ][ 1 ] && board_[ 2 ][ 0 ] == board_[ 0 ][ 2 ] )
	   {
	   status = board_[ 2 ][ 0 ];
	   cout << "Player" << status << "wins!!!";	  
	   return status;
	   }	
   // check for win in rows
   for ( a = 0; a < 3; ++a )

      if ( board_[ a ][ 0 ] != ' ' && board_[ a ][ 0 ] == 
         board_[ a ][ 1 ] && board_[ a ][ 0 ] == board_[ a ][ 2 ] )
		  {
		  status = board_[ a ][ 0 ];
          cout << "Player" << status << "wins!!!";
		  return status;
		  }
   // check for win in columns
   for ( a = 0; a < 3; ++a )

      if ( board_[ 0 ][ a ] != ' ' && board_[ 0 ][ a ] == 
         board_[ 1 ][ a ] && board_[ 0 ][ a ] == board_[ 2 ][ a ] )
		  {
		  status = board_[ 0 ][ a ];
          cout << "Player" << status << "wins!!!";
		  return status;
		  }
   // check for a completed game
   for ( int r = 0; r < 3; ++r )

      for ( int c = 0; c < 3; ++c )

         if ( board_[ r ][ c ] == ' ' )
			 {
			 status = 'C';
             return status; // game is not finished
			 }

   status = ' ';	
   return status; // game is a draw
} // end function gameStatus


void ttt::printBoard() 
{
   cout << "   0    1    2\n\n";

   for ( size_t x = 0; x < 3; ++x ) 
   {
      cout << x;
	char value = 1;
      for ( size_t y  = 0; y < 3; ++y ) 
      {
         cout << setw( 3 ) <<  static_cast < char > (board_[ x ][ y ]);

         if ( y != 2 )
            cout << " |";
      } // end for

      if ( x != 2 )
         cout << "\n ____|____|____\n     |    |    \n";
   } // end for

   cout << "\n\n";
} 



bool ttt::IsValidLocation(size_t x, size_t y)
{
    if ( x < 0 || x > 3 )
    {
        return false;
    }
    else if ( y < 0 || y > 3 )
    {
        return false;
    }
    else if ( board_[ x ][ y ] != ' ' )
    {
        return false;
    }
    else
    {
        return true;
    }
}
bool ttt::OccupySquare(size_t x, size_t y, char value)
{
	bool valid = IsValidLocation( x, y );

	if ( !IsValidLocation( x, y ))
    {
	    
			return true;
	}
	
}

void ttt::twoComp()
{	
	size_t x=0;
	size_t y=0;
	char value = 0;
	int counter = 1;
	int turn;

	ttt g;
	cout << "Computer vs. Computer\n" << endl;
	g.printBoard();

		do
	{
		cout << "Player" ;
		if ( counter % 2 == 1 )
			{
				cout << " X ";
			}
		else if ( counter % 2 == 0 )
			{
				cout << " O ";
			}
		cout << "enter coordinates:" << endl;
		cin >> x >> y;

		if ( counter % 2 == 1 && IsValidLocation( x, y ) )
			{
				board_[ x ][ y ] = 'X';
				counter++; 
				cout << board_[ x ][ y ];
				printBoard();
				g.CheckForWinner();
			}

		if ( counter % 2 == 0 && IsValidLocation( x, y ) )
			{				
				board_[ x ][ y ] = 'O';
				counter++;
				cout << board_[ x ][ y ];
				printBoard();		
				g.CheckForWinner();
			}
		
	} while (  OccupySquare( x, y, value ));
}

void ttt::compHuman()
{
	ttt g;
	cout << "Human vs. Computer\n" << endl;
	g.printBoard();

}

void ttt::twoHuman()
{
	ttt g;
	cout << "Human vs. Human\n" << endl;
	g.printBoard();
	size_t x=0;
	size_t y=0;
	char value = 0;
	int counter = 1;
	int turn;

	
	do
	{
		cout << "Player" ;
		if ( counter % 2 == 1 )
			{
				cout << " X ";
			}
		else if ( counter % 2 == 0 )
			{
				cout << " O ";
			}
		cout << "enter coordinates:" << endl;
		cin >> x >> y;

		if ( counter % 2 == 1 && IsValidLocation( x, y ) )
			{
				board_[ x ][ y ] = 'X';
				counter++; 
				cout << board_[ x ][ y ];
				printBoard();
				g.CheckForWinner();
			}

		if ( counter % 2 == 0 && IsValidLocation( x, y ) )
			{				
				board_[ x ][ y ] = 'O';
				counter++;
				cout << board_[ x ][ y ];
				printBoard();		
				g.CheckForWinner();
			}
		
	} while (  status != ' ' );




}


bool ttt::IsScratch()
{
	if ( counter == 9 )
		return true;
}

[kooth]

In your functions that return Booleans, half of the time you explicitly return a value; however, the other half of the time your functions return whatever is on the stack (usually non-zero. For example IsScratch() could be coded this way:

bool ttt::IsScratch()
    {
     int brc = false;

    if( 9 == counter )
        brc = true;

    return brc;

    }
        /*    IsScratch()    */