code error

[firix]

Hi,

Why this code does not work?

class Name {
	char *mp;
	int mlen;
public:
	Name(const char *pname) : mlen(strlen(pname)), mp(new char[mlen + 1]) 
	{
		strcpy(mp, pname);
	} 
	void display()const 
	{
		cout << mp << endl;
	}
};


int main()
{
	Name name("Firix bills");

	name.display();

	return 0;
}

[Disch]

class Name {
	char *mp;  // since mp is declared first in the class, it in initialized first
	int mlen;  // mlen is initialized after mp
public:
   // the order you put them in here doesn't matter:
	Name(const char *pname) : mlen(strlen(pname)), mp(new char[mlen + 1])

   // therefore, you are using mlen before it was initilized. 

To correct this, declare mlen before mp, or allocate mp in the body of the ctor.


Also, don't forget to delete[] mp in your dtor and write a proper copy ctor and assignment operator.

[Bazzy]

Because mlen gets initialized after mp
The order of initialization of class members depends on the order of their declarations
Your compiler should give a warning on the code above

[edit] slow connection...

[firix]

ok.