overloading operators issue with addition

[Volapiik]

Having issues with adding objects. It seems to work when adding two, ex: 2.34 + 34.57 = 36.81, but fails when adding 3 or more ex: 6.78 + 9.81 + 4.59 = 79.59 <-- the total seems to increase drastically for some reason.

The median and sorting, and > functions are working, so the issue might be somewhere in the ostream, istream, or + functions. I used cout a whole bunch of places and most of the abnormal numbers seems to appear in the + function.

Thanks in advance.

Header:

#ifndef LAB2_H
#define LAB2_H 
#include <iostream>
#include <string>
#include <cstdlib>

using namespace std;

class DollarAmount
{
	double dollar = 0.00;
	double cents = 0.00;
        double avg = 0.00;
	int maxsequence = 0;
	string number;
	public:
	
		DollarAmount(double num1 = 0, double num2 = 0);
		
		double getavg() const { return avg; };

		double getDollar() const { return dollar; };

		double getCent() const { return cents; };

		int getmaxsequence() const { return maxsequence; };

                friend istream& operator >> (istream& ins, DollarAmount& arg);

		friend ostream& operator << (ostream& out, const DollarAmount& arg);

		friend DollarAmount operator + (const DollarAmount& arg1, const DollarAmount& arg2);

		friend bool operator > (const DollarAmount& arg1, const DollarAmount& arg2);

		void sortobjects(DollarAmount a[], int length);

		void median(DollarAmount a[], int length);

		//All of the below functions are from lab 1

		

Functions:

#include <iostream>
#include <string>
#include <cstdlib>
#include "lab2.h"

using namespace std;


DollarAmount::DollarAmount(double num1, double num2)
{
	
	dollar = num1;
	cents = num2;
	
}

istream& operator >> (istream& ins, DollarAmount& arg)
{
	double num1 = 0.00;
	double num2 = 0.00;
	//int num1 = 0;
	//int num2 = 0;
	char ch;
	string s;
	double num3;
	bool wrongInput = false;
	
   //ins >> num1 >> ch >> num2;
	ins >> num3;
	s = to_string(num3);
	arg.number = s;
	int index = s.find(".");
	num1 = atof(s.substr(0, index).c_str());
	num2 = atof(s.substr(index, 3).c_str()); 
	
	do
	{
		if (wrongInput == true)
		{
			cout << "Enter the expenditure record (e.g., $1.95, coffee, enter -1 to end):$";
			ins >> num1 >> ch >> num2;
		}
		
		else if (cin.fail() || num1 < 0 || num1 > 9999 || num2 > 99) //in case the above fails, e.g., ten dollor five cents...
		{
			cout << "Wrong input types. Try again:\n";
			cin.clear(); //clear the error flags in cin 
			cin.ignore(2048, '\n'); //ignore everthing in the input buffer, up to 2048 char, 
			//up to the newline char =< ignore the rest of the line
			wrongInput = true;
		}
		else
			wrongInput = false;
	} while (wrongInput == true || num1 < 0 || num1 > 9999 || num2 > 99); // if input false ask for input again
	
	arg.dollar = num1;
	arg.cents = num2;
	arg.maxsequence = arg.getmaxsequence() + 1;
	return ins;
}

ostream& operator << (ostream& out, const DollarAmount& arg)
{
	out << arg.getDollar() + arg.getCent();
	return out;
}

DollarAmount operator + (const DollarAmount& arg1, const DollarAmount& arg2)
{
	DollarAmount temp;
	double sum = 0.00;
	double x = 0.00;
	double y = 0.00;
	string z;

	temp.dollar = 0.00;
	temp.cents = 0.00;

	x = arg1.dollar + arg1.cents;
	
	y = arg2.dollar + arg2.cents;
	sum = x + y;
	cout << "This is the sum: " << sum << endl;

	z = to_string(sum);
	int index = z.find(".");

	temp.dollar = atof(z.substr(0, index).c_str());
	temp.cents = atof(z.substr(index + 1, 2).c_str());
	cout << "This is the dollar: " << temp.getDollar() << endl;
	cout << "This is the cents: " << temp.getCent() << endl;

    return temp;
}

bool operator > (const DollarAmount& arg1, const DollarAmount& arg2)
{
	DollarAmount temp;
	double x, y;
	
	x = arg1.dollar + arg1.cents;

	y = arg2.dollar + arg2.cents;
	
	if (x > y)
		return true;
	else
		return false;
}

void DollarAmount::sortobjects(DollarAmount a[], int length)
{
	int i;
	int last = length - 1;  //point to the index of last element in unsorted part of the array 

	for (int pass = 0; pass < length; pass++)
	{
		//a[0]...a[last] is not sorted 
		//repeated bubble the largest element in this range to the end ... 
		for (i = 0; i <= last - 1; i++)
		{
			if (a[i] > a[i + 1])
			{
				//swap 
				DollarAmount tmp;
				tmp = a[i + 1];
				a[i + 1] = a[i];
				a[i] = tmp;
			}
		}
		//at this point, the largest element in a[0...last] is stored in a[last]

		//unsorted part is now a[0...last-1]
		last = last - 1;
	}
}


void DollarAmount::median(DollarAmount a[], int length)
{
	DollarAmount temp;
	int mid;
	double average = 0.00;
	double x = 0.00;
	double y = 0.00;

    if (length % 2 == 0)
	{
		mid = length / 2;
		int test = mid - 1;
		x = a[mid].dollar + a[mid].cents;
		y = a[test].dollar + a[test].cents;
		average = (x + y) / 2.00;
		temp.avg = average;
		cout << temp.getavg();
	}
	else
	{
		mid = length / 2;
		x = a[mid].dollar + a[mid].cents;
		average = x;
		temp.avg = average;
		cout << temp.getavg();
    }
	
}

main:

#include <iostream>
#include <string>
#include <cstdlib>
#include "lab2.h"

using namespace std;

const int INIT_SIZE = 10;
const int a = 9;
const int b = 10;
const int c = 8;

int main()
{
    DollarAmount* arr = new DollarAmount[INIT_SIZE];
    DollarAmount* ptr = NULL;
    int avg = 0;
    int arr_size = INIT_SIZE;
    int arr_len = 0; // actual number of objects stored in it , also the index
      // of next free slot in arr

    bool lastInput = false;

    do 
    {
        if (arr_len == arr_size)
        { // the array is full, need to grow! 

           //allocate an array double the cur_size
            ptr = new DollarAmount[arr_size * 2];

            //copy each element in arr into the new array that ptr points to... 
            // Todo: please figure out how to do this...(hint: use a for loop)
            for (int i = 0; i < arr_size; i++)
            {
                ptr[i] = arr[i];
            }

            //now we delete the current arr
            delete[] arr;
            arr = ptr;
            arr_size = arr_size * 2;
        }

        cout << "Enter the expenditure record (e.g., $1.95, coffee, enter 0.0 to end):$";
        cin >> arr[arr_len];  //read in a dollar amount from cin we will allow input such as 0.0

        //If the last read dollar amount is 0.0, then it's the end 
        if (arr[arr_len].getDollar() == 0 && arr[arr_len].getCent() == 0)
            lastInput = true;
        else //we only increment arr_len for input that's not 0.0
            arr_len++;


    } while (lastInput == false);

    DollarAmount total, temp, loopingtotal;
    
    
    total = arr[0] + arr[1];
    //cout << "The first total: " << total << endl;
    //cout << "This is sum of first two: " << total;
    
    //A loopt to add all DollarAmount up, and display the total 
    
    for (int i = 2; i < arr_len; i++)
    {
        total = total + arr[i];
        cout << "The total for this " << i << " time is: " << total << endl;
    }
    //cout << "This is the sum after loop " << total;
   
    //Call Sort function to sort the array of DollarAmount 
    temp.sortobjects(arr, arr_len);
    //Display the sorted array, and the median 
    cout << "Sorted list of expenditure:" << endl;
    for (int i = 0; i < arr_len; i++)
    {
        cout << arr[i] << endl;
    }
    
    //cout << "This is the total cents: " << total.getCent();
    //cout << "This is the total dollar: " << total.getDollar();
    cout << "The total is $" << total.getDollar() << "." << total.getCent();
    cout << " (";
    cout << "The median is ";
    temp.median(arr, arr_len);
    cout << "." << endl;
    cout << "Bye!";
    return 0;
}

[keskiverto]

Perhaps you should look at what dutch wrote in your previous thread (about same program): http://www.cplusplus.com/forum/beginner/267809/#msg1152341

[Volapiik]

previous post had a diff issue that was solved. But I figured out this new issue as well.