Not sure if my insert function does it's job okay.

I get zero output when I run my program.
1
2
3
4
5
6
7
8
9
10
11
12
13
14
15
16
17
18
19
20
21
22
23
24
25
26
27
28
29
30
31
32
33
34
35
36
37
38
39
40
41
42
43
44
45
46
47
48
49
50
51
52
53
54
55
56
57
58
59
60
61
62
63
64
65
66
67
68
69
70
71
72
73
74
75
76
77
78
79
80
81
82
83
84
85
86
87
88
89
90
91
92
93
94
95
96
97
98
99
100
101
102
103
104
105
106
107
108
109
110
111
112
113
114
115
116
117
118
119
120
121
122
123
124
125
126
127
128
129
130
131
132
133
134
135
136
137
138
139
140
141
142
143
144
145
146
147
148
149
150
151
152
153
154
155
156
157
158
159
160
161
162
163
164
165
166
167
168
169
170
171
172
173
174
175
176
177
178
179
180
181
182
183
184
185
186
187
188
189
190
191
192
193
194
195
196
197
198
199
200
201
202
203
204
205
206
207
208
209
210
211
212
213
214
215
216
217
218
219
220
221
222
223
224
225
226
227
228
229
230
231
232
233
234
235
236
237
238
239
240
241
242
243
244
245
246
247
248
249
250
251
252
253
254
255
256
257
258
259
260
261
262
263
264
265
266
267
268
269
270
271
272
273
274
275
276
277
278
279
280
281
282
283
284
285
286
287
288
289
290
291
292
293
294
295
296
297
298
299
300
301
302
303
304
305
306
307
308
309
310
311
312
313
314
315
316
317
318
319
320
321
322
323
324
325
326
327
328
329
330
331
 #include<iostream>
#include<cassert>
using namespace std;

template<class Type>
struct nodeType
{
    Type info;
    nodeType<Type> *link;
};
template<class Type>
class linkedListType
{
 //   friend ostream& operator<<(ostream&, const linkedListType<Type>&);

public:
   const linkedListType<Type>& operator=( const linkedListType<Type>&);
void initializeList();
bool isEmptyList();
int length();
 void destroyList();
 Type front();
 Type back();
bool search(const Type& searchItem);
void insertFirst(const Type& newItem );
void insertLast(const Type& newItem);
void insertNode(const Type& newItem)  ; 
    void insert(const Type& newItem) ;
void deleteNode(const Type& deleteItem);
linkedListType();
linkedListType(const linkedListType<Type>& otherList);
~linkedListType();

//protected:
   int count;
nodeType<Type> *first;
nodeType<Type> *last;

private:
    void copyList(const linkedListType<Type>& otherList);
};
template<class Type>
bool linkedListType<Type>::isEmptyList()
{
    return(first == NULL);
}
template<class Type>
linkedListType<Type>::linkedListType()
{
    first = NULL;
    last = NULL;
    count = 0;
}
template<class Type>
void linkedListType<Type>::destroyList()
{
    nodeType<Type> *temp;
    while(first != NULL)
    {
        temp = first;
        first = first-> link;
        delete temp;
    }
    last = NULL;
    count = 0;
}
template<class Type>
void linkedListType<Type>::initializeList()
{
    destroyList();
    }
template<class Type >
ostream& operator<<(ostream& osObject, const linkedListType<Type>& list)
{
   nodeType<Type> *current;
   current = list.first;
    while(current != NULL)
   {
        osObject<<current->info<<" ";
      current = current->link;
   }
    return osObject;
}
template<class Type >
int linkedListType<Type>::length()
{
    return count;
}
template<class Type >
Type linkedListType<Type>::front()
{
    assert(last != NULL);
    return first->info;
}
template<class Type>
Type linkedListType<Type>::back()
{
    assert(last != NULL);
    return last->info;
}
template<class Type>
bool linkedListType<Type>::search(const Type& searchItem)
{
    nodeType<Type> *current;
    bool found;
    current = first;
    found = false;
    while(current != NULL && !found)
        if(current->info == searchItem)
          found = true;
        else
           current = current->link;
    return found;
}
template<class Type>
void linkedListType<Type>::insertFirst(const Type& newItem)
{
    nodeType<Type> *newNode;
    newNode = new nodeType<Type>;
    assert(newNode != NULL);
   newItem->info = newItem;
    newNode->link = first;
    first = newNode;
    count++;
    if(last == NULL) ;
    last = newNode;
}
template<class Type>
void linkedListType<Type>::insertLast(const Type& newItem)
{
    nodeType<Type> *newNode;
    newNode = new nodeType<Type>;
    assert(newNode != NULL);
    newNode->info = newItem;
    newNode->link = NULL;
    if(first == NULL)
    {
        first = newNode;
        last = newNode; 
        count++;
    }
    else
    last->link = newNode;
    last = newNode;
    count++;
}
template<class Type>
void linkedListType<Type>::insertNode(const Type& newItem)
{
    nodeType<Type> *current;
    nodeType<Type> *trailCurrent;
    nodeType<Type> *newNode;
    bool found;
    newNode = new nodeType<Type>;
    assert(newNode != NULL);
    if(first == NULL)
    {
        first = newNode;
        count++;

}
    else
    {
    current = first;
    found = false;
        while(current != NULL && !found)
        if(current->info >= newItem)
        found = true;
        else{
            trailCurrent = current;
        current = current->link;
            
        }
        if(current == first)
        {
        newNode->link = first;
            first = newNode;
            count++;
    }
        else
{
        trailCurrent->link = newNode;
            newNode->link = current;
            count++;
    }
}
}
template<class Type>
void linkedListType<Type>::insert(const Type& newItem)
{
    nodeType<Type> *newNode;
    newNode = new nodeType<Type>;
    assert(newNode != NULL);
    newNode->info = newItem;
    newNode->link = NULL;
    
    count++;

}
template<class Type>
void linkedListType<Type>::deleteNode
(const Type& deleteItem)
{
    nodeType<Type> *current;
    nodeType<Type> *trailCurrent;
    bool found;
    
    if(first == NULL)
        cerr<<"Cannot delete from an empty list.\n";
    else
    {
        if(first->info == deleteItem)
        {
            current = first;
            first = first->link;
            count--;
            if(first == NULL)
                last = NULL;
            delete current;
        }
        else
        {
        found = false;
        trailCurrent = first;
            current = first->link;
            
            while(current != NULL && !found)
            {
                if(current->info != deleteItem)
                {
                    trailCurrent = current;
                    current = current->link;
                }
                else
                    found = true;
            }
            if(found)
            {
            trailCurrent->link = current->link;
                count--;
                if(last == current)
                last = trailCurrent;
                delete current;
        }
        else
            cout<<"Item to be deleted is not in  the list."<<endl;

         }
    }
}
    
template<class Type>
void linkedListType<Type>::copyList (const linkedListType<Type>& otherList)
{
    nodeType<Type> *newNode;
    nodeType<Type> *current;
    if(first != NULL)
        destroyList();
    if(otherList.first == NULL)
    {
        first = NULL;
        last == NULL;
        count = 0;
    }
    else
    {
        current = otherList.first;
        count = otherList.count;
        //Copy the first node
      first = new nodeType<Type>;
      assert(first != NULL);
      first->info = current->info;
      first->link = NULL;
        last = first;
        current = current->link;
        //Copy the remaining list
    while(current != NULL)
    { 
        newNode = new nodeType<Type>;
        assert(newNode != NULL);
        newNode->info = current->info;
        newNode->link = NULL;
            
        last->link = newNode;
        last = newNode;
            
        current = current->link;
            }
    }                 
 }
template<class Type>
linkedListType<Type>::~linkedListType()
{
    destroyList();
    }
template<class Type>
linkedListType<Type>::linkedListType (const linkedListType<Type>& otherList)
{
    first = NULL;
    copyList(otherList);
    }
template<class Type>
const linkedListType<Type>& linkedListType<Type>::operator=(const linkedListType<Type>& otherList)
{
    if(this != &otherList)
       copyList(otherList);
    
     return *this;
}
int main()
{
    linkedListType<int> list1, list2;
    int num;
    cout<<"Enter numbers ending with -999.\n";
    cin >> num;
    while(num != -999)
    {
      list1.insert(num);
        cin>>num;
    }
    cout<<endl;
    cout<<"List1: " <<list1 <<endl;
    list2 = list1;
    cout<<"List2: "<< list2 << endl;
    cout<<"Enter the number to be deleted"<<endl;
   cin >> num;
 //   <<endl; 
    list2.deleteNode(num);
    cout<<"After deleting node: " <<"List2 : " <<endl <<list2 <<endl;
    return 0;
}
























I get zero output when I run my program.
331 lines of code has given you no output. And this is the first time you've tested it? This is a joke right?

If you are serious the best thing to do is go back to the last version that ran.

As a tip, a method with more than about 5 or 6 lines of code is not worth debugging. It's far too complicated. It should be re-written.



insert is no good.
depending on where you want to insert, which, if unsorted, would be at the head to make it efficient, you need to connect the pointers (you set to null in your insert).
so
list is empty, so its pointer is null.
new guy's next = head/main list pointer, not null, to do it as I described. If you want it inserted in order or at the far end, you need more.

looks like this...
null / empty,
insert 3
3 -> null //end of list, which happened to be the empty list pointer, how handy!
insert 7
7->3->null
and so on.
Last edited on
Topic archived. No new replies allowed.