CYK ALGORTIHM, RUN TIME ERROR

[rahul yadav]

Program : CYK Algorithm,
I did it using strings and vectors.
Code is compiling without any syntax errors and also asking me to Enter string
but there is something wrong in the 69th line i guess..
It is saying CYK.exe has stopped working!
can anyone please help me out with this!

 #include<iostream>
#include<stdio.h>
#include<string.h>
#include<vector>
#include<fstream>
#include<cstddef>
using namespace std;

int main()
{
      ifstream fin;
      fin.open("CYK.txt");
      vector<string> pr;
      string s,str="";
      
      while(!fin.eof())
      {
       getline(fin,s);
       cout<<s<<endl;
       pr.push_back(s);                 
      }
      
	  int nor = pr.size();
      for(int i=0; i<nor;i++)
      {
              if(pr[i][0]=='S')
              {
                               str = pr[i];
                               break;
              }
      }
     
       if(str =="") 
       { 
              cout<<" Invalid Grammar";
              return 0;
       }
      
       char rs[nor];
       for(int i=0; i<nor;i++)
       rs[i]= pr[i][0];
   
       string temp;
       vector<string> ls[nor];
       
       size_t f;
      for(int i=0; i<nor;i++)
      {
        f = pr[i].find_first_of('|');
        temp = pr[i].substr(3,f-3);
        while(f!=std::string::npos)
        {
        	int t=f+1;
			f=pr[i].find('|',f+1);
        	temp = pr[i].substr(t,f-t);
        	ls[i].push_back(temp);
        }
     }
		
	 
      string ip;
      cout<<"Enter String = ";
      cin>>ip;
      string tempo="";
      int len = ip.length();
      temp ="";
   
      cout<<"dhjdfal";
      vector <string> TT[len];
       cout<<"dhjdfal";
 
 
 // Initilaizing the Triangle table;                      
    for(int i=0; i<len;i++ )
	{
    	for(int j=0; j<len; j++)
		{
			TT[i].push_back("");
	    }
    }
 
//caluclating the first row oF TT;    
	  for(int i=0; i<len; i++)
      {    
	          
              temp = temp + ip[i];
              for(int k=0; k<nor;k++)
              {
                
                for(int j=0; j<ls[k].size();j++)
                {      
				  if(ls[k][j].compare(temp)==0)
                  TT[0][i]=TT[0][i]+rs[k];
                }
              }
      }
 //caluclating the rest of the rows;
int x,y;

for(int i=1; i<len; i++)
{
	for(int j=0; j<len-i;j++)
	{
		int m = (TT[i-1][j].size())*(TT[i-1][j+1].size());
		vector<string> temp(m);
		int p=0;
        for(int b=0; b<TT[i-1][j].size();b++)	
        {
        	for(int n=0;TT[i-1][j+1].size();n++ )
        	{
        		temp[p]="";
        		temp[p]= temp[p]+ TT[i-1][j][b] + TT[i-1][j+1][n] ;
        		p++;
        	}
        }

       TT[i][j]="";
       for(int g=0; g<m; g++)
       {
       	for(int h=0; h<nor; h++ )
       	{
       		for(int u=0; u<ls[h].size();u++)
       		{
       			if(temp[g].compare(ls[h][u])==0)
       			TT[i][j] = TT[i][j] + rs[h] ;
       		}
        }
	   }

	x=i;
	y=j;
	}
	
}
 
 if(TT[x-1][y-1]=="")
 	cout<<"The given input string is NOT in the grammar";

 else
   cout<<"Congrats! The input string belongs to the grammar" ;   
      
   return 0;  
}         

[Peter87]

Line 69 you create an array of len vectors. Each vector will be empty so on line 78 you try to access elements that doesn't exists. Before you access an element in a vector you have to make sure it has that many elements.

You can use push_back to add one element

// Adds an empty string to the end of vector TT[i]
TT[i].push_back("");

Or you might want to use resize.

// Sets the size of vector TT[i] to len (All new string elements will be empty)
TT[i].resize(len);

[rahul yadav]

@peter87 Thanks a lot for your help.
I've rectified it.
But my problem is not solved yet.
still getting the same error.
Note that the cout statement in line 70 is NOT executing!!
Kindly help

[Peter87]

How do you know that it's not executing? You don't flush cout so it might very well run even though you see no output. Use one of the following lines instead.

cout<<"dhjdfal"; cout.flush();
cout<<"dhjdfal" << flush;
cout<<"dhjdfal" << endl;  // This will also print a newline character. 

[rahul yadav]

I used one of those lines as you said and I tried all three of them and I'm seeing no output of that 70th line.
May be according to you that cout statement is executing but not showing output. okay!
But where is the problem now?
Why is my program not executing??
What is the problem now??
I've done everything as you told :\
HELP!!

[Peter87]

When I run your program I don't get past the first loop (line 16-21) because I don't have the file CYK.txt. Does it give any output at all for you? Maybe you should add a few more cout statements (with flushing) or simply use a debugger to find out where things go wrong.

[ne555]

http://www.cplusplus.com/forum/general/112111/


> vector <string> TT[len];
illegal, the size of the array must be constant.


Also, your file reading is incorrect. Loop against the reading operation instead

      while( getline(fin, s) )
       pr.push_back(s);

[rahul yadav]

just create a text file CYK.txt in the same directory in which you downloaded this code and write the following in the file

S->AB|BC
A->BA|a
B->CC|b
C->AB|a

and save it.
and yes it gives me output of the file contents as i asked and also asks me to "Enter the string" .
and after i enter the string.
it gives the output as dhjdfal and hungs.. help!!

[ne555]

> and after i enter the string.
¿what string?


read the link

If your program hung, you may terminate it. The debugger should show what was executing.

[rahul yadav]

changed the 69 line as

vector<string> TT[100];

and

while(getline(fin,s))
pr.push_back(s);

still same problem.
HELP!!!