how do i count the amount of bonus from salary? || structures

[laura fidarova]

Q: info about employees contains their last, first, dad's names, position, gender, the date they joined, salary and bonus.

Bonus is not filled(declared?)

Calculate the bonus for each employee using this info:
5% is they worked for 5 years and more; 10% for >=10 years; 30% for >=20 years

....

i have some idea in my head but i just don't get how to actualize it.
i'm thinking of getting another function for calculating the bonus from the salary, but i don't know how to bring the date there

ps: if i just use the year they joined instead of the date it'll be okay by my teacher, since it's less complicated and doesn't require using libraries i'm not familiar with

thanks in advance

 #include <iostream>
#include <string>
using namespace std;

struct Employee
{
    string LastName;
    string FirstName;
    string DadsName;
    string position;
    char sex;
    int year_joined;
    double salary;
    double bonus;
};

void EmployeeChart(const Employee& employee)
{
    cout << "Last name: " << employee.LastName << '\n';
    cout << "First name: " << employee.FirstName << '\n';
    cout << "Dad's name: " << employee.DadsName << '\n';
    cout << "Position: " << employee.position << '\n';
    cout << "Gender: " << employee.sex << '\n';
    cout << "Year joined: " << employee.year_joined << '\n';
    cout << "Salary: " << employee.salary << '\n';
    cout << "Bonus: " << employee.bonus << '\n';
}

/*int Bonus(const Employee& amount)
{
    for()
}
*/

int main()
{
    Employee laura = { "Laura", "Fidarova", "Alanovna", "stud", 'F', 2015, 45000 }; // +bonus in the end 
    EmployeeChart(laura);
    return 0;
}

[thmm]

To calc the duration of the employment you need to get the current year first.

int get_current_year() // #include <ctime>
{
  time_t t = time(nullptr);   
  struct tm* now = localtime(&t);

  return now->tm_year + 1900;
}

Now you can try to write a function to calculate the bonus.

[seeplus]

To determine the number of years between a specified year and the current year, consider:

#include <ctime>

int years(int year)
{
	const auto t {std::time(nullptr)};

	return (std::localtime(&t)->tm_year + 1900) - year;
}

[laura fidarova]

thank you so much! am i on the right track or even close to it? i'm a little confused about how to correctly use stuctures. is that a correct function for Bonus? is it is, where and how do i put it so it works as needed?

#include <iostream>
#include <string>
#include<ctime>
using namespace std;

struct Employee
{
    string LastName;
    string FirstName;
    string DadsName;
    string position;
    char sex;
    int year_joined;
    double salary;
    double bonus;
};

void EmployeeChart(const Employee& employee)
{
    cout << "Last name: " << employee.LastName << '\n';
    cout << "First name: " << employee.FirstName << '\n';
    cout << "Dad's name: " << employee.DadsName << '\n';
    cout << "Position: " << employee.position << '\n';
    cout << "Gender: " << employee.sex << '\n';
    cout << "Year joined: " << employee.year_joined << '\n';
    cout << "Salary: " << employee.salary << '\n';
    cout << "Bonus: " << employee.bonus << '\n';
}

int years(int year)
{
    const auto t{ time(nullptr) };

    return (localtime(&t)->tm_year + 1900) - year;
}

double Bonus(const Employee& amount)
{
    if (years(amount.year_joined) >= 5 && years(amount.year_joined) <= 10)
        return amount.salary * 5 / 100;
    
    if (years(amount.year_joined) > 10 && years(amount.year_joined) < 20)
        return amount.salary * 10 / 100;

    if (years(amount.year_joined) >= 20)
        return amount.salary * 30 / 100;
}


int main()
{
    Employee laura = { "Laura", "Fidarova", "Alanovna", "stud", 'F', 2015, 45000 };
    EmployeeChart(laura);
    return 0;
}

[seeplus]

In Bouus, there's no need to keep using the function years() - you just need to use it once and save the result in a variable.

double Bonus(const Employee& amount)
{
	const int yrs_wrkd = years(amount.year_joined);

	int bnsper = 0;

	if (yrs_wrkd >= 5)
		bnsper += 5;

	if (yrs_wrkd >= 10)
		bnsper += 5;

	if (yrs_wrkd >= 20)
		bnsper += 20;

	return amount.salary * bnsper / 100.0;
}

[keskiverto]

The original had a flaw:

double bonus() {
  if ( x ) return y;
  // compiler should warn: this function does not return a value
}

When x is false (has worked under 5 years), the function does not return a value.

The seeplus version always returns a value.

However, the incremental way to accumulate the bonus might be hard to read.

int bnsper = 0;
if (yrs_wrkd >= 5)
  bnsper += 5;
if (yrs_wrkd >= 10)
  bnsper += 5;
if (yrs_wrkd >= 20)
  bnsper += 20;

// equals
int bnsper = 0;
if (yrs_wrkd >= 20)
  bnsper = 30;
else if (yrs_wrkd >= 10)
  bnsper = 10;
else if (yrs_wrkd >= 5)
  bnsper = 5;

[laura fidarova]

okay, thank you so much!

[dhayden]

Lastly, bonus should be a method of Employee. Don't store the bonus value since it can change if the salary or date changes. So something like this (untested):

struct Employee
{
    string LastName;
    string FirstName;
    string DadsName;
    string position;
    char sex;
    int year_joined;
    double salary;
    double bonus();
};

double Employee::bonus()
{
    int yearsWorked = years(year_joined);
    double rate;
    // 5% if they worked for 5 years and more; 10% for >=10 years; 30% for >=20 years
    if (yearsWorked >= 20) {
        rate = 0.30;
    } else if (yearsWorked >= 10) {
        rate = 0.10;
    } else if (yearsWorked >= 5) {
        rate = 0.05;
    } else {
        rate = 0.0;
    }
    return salary * rate;
}