Manual Reverse string [CHALLENGE]

[xoox]

I was challenged to create a function that will reverse a given string, and unfortunately running out of time. this is my last resort


I was restricted to use other functions and add new lines.

I was challenged to finish ONLY this template.

  #include <iostream>
using namespace std;
void stringRev(char *s);

int main()
{
	char str[]="Happy Day";
	cout << stringRev(str);
	system ("pause > 0");
	return 0;
}

char* stringRev(char *s)
{	
	char* tmp;
	tmp = new char;
	int i, cnt(0);
	for( ; ; )
	{
		cout <<  s[i] << endl;
		cnt++;
	}
	for( ; ; )
	{
		tmp[] = s[   - - ];
	}
	tmp[i]='\0';
	return tmp;
	
	
}

[ne555]

well, you failed, better luck next time

cout << stringRev(str); //memory leak

char* stringRev(char *s)
{	
	char* tmp;
	tmp = new char; //¿how many characters do you need?
	int i, cnt(0);
	for( ; ; )
	{
		cout <<  s[i] << endl; //¿why are you doing output here?
		cnt++;
	}
	for( ; ; )
	{
		tmp[] = s[   - - ];
	}
	tmp[i]='\0';
	return tmp;
}

[Duthomhas]

Hint: no need to create a new string or mess with char arrays[].

Hint 2: how many swaps are needed to fully exchange every pair of characters?

[markyrocks]

This may be wrong, might not even compile (probably wont)

But this was my take (done in a phone so go easy on me). But you ain't never gonna learn getting answers off a forum like this

[Code]

#include <iostream>
using namespace std;
void stringRev(char *s);

int main()
{
char str[]="Happy Day";
cout << stringRev(str);
system ("pause > 0");
return 0;
}

char* stringRev(char *s)
{
char* tmp;
tmp = new char;
int i, cnt;
for( i=0;s[i]!=’\0’;i++ ; )
{
cout << s[i] << endl;
cnt++;
}
for( i=0; i<cnt; i++)
{
tmp[i] = s[cnt-i];
}
tmp[i]='\0';
For(i=0;i<cnt;i++){

Cout<<”tmp[i] “<<tmp[i]<<” s[i] “<<s[i]<<endl;
}
return tmp;


}

[/code]

Idk why this looks like this....whatever

I just noticed that there maybe some dereferenceing that needs to happen to set and display the data. I'm not really that thoroughly schooled in pointers yet to really be able to tell.

[mbozzi]

#include <utility>
#include <iostream>

char* reverse_string(char* s, int sz)
{
  for (int beg = 0, end = sz - 1; beg < end; )
    std::swap(s[beg++], s[--end]);
  return s;
}

int main()
{
    char s[] = "Hello";
    std::cout << "reverse(" << s << ") = " << reverse_string(s, sizeof s) << '\n';  
}